[Webkit-unassigned] [Bug 112240] execCommand("RemoveFormat") might remove format after the selection

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 16 11:33:48 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=112240


Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #198353|review?                     |review+
               Flag|                            |




--- Comment #12 from Ryosuke Niwa <rniwa at webkit.org>  2013-04-16 11:32:05 PST ---
(From update of attachment 198353)
View in context: https://bugs.webkit.org/attachment.cgi?id=198353&action=review

Thanks for the fix.

> Source/WebCore/ChangeLog:7
> +

Please explain why the bug was caused and how you fixed it akin to what you've posted on the bug.

> Source/WebCore/editing/ApplyStyleCommand.cpp:1093
> +    if (pushDownEndContainer && pushDownEndContainer->isTextNode()
> +        && !pushDownEnd.computeOffsetInContainerNode())

We can probably fit all of this in one line.

> Source/WebCore/editing/ApplyStyleCommand.cpp:1108
> +    // The tree is changed and the code below, in particular calls to Position::upstream/downstream(),

Nit: The tree may have changed.
Where are we using upstream/downstream?

> Source/WebCore/editing/ApplyStyleCommand.cpp:1109
> +    // rely in an up-to-date layout.

Nit: rely on.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list