[Webkit-unassigned] [Bug 113124] Add animation support for WebP images

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=113124





--- Comment #5 from Urvang Joshi <urvang at google.com>  2013-04-15 11:25:37 PST ---
> Other ports use webp and hence WEBPImageDecoder.{cpp,h}, but they won't get 
> here (animation) until they upgrade their bots and builds to use libwebp 0.3.0.  
> Does that answer your question?

ok good, so this patch is relevant for Webkit too (and not just Blink). Just wanted to clarify that.

> One thing I noticed with this patch: are you are creating m_demux once only 
> from the input m_data->data()? That's gonna hurt if the demux maintains 
> pointers into that m_data->data() with progressive decoding because the
> underlying data may be moved around (consolidated) on subsequent m_data->data()
> calls, bug 104302.  Any pointers to the original data may become invalid, 
> meaning we'd crash on access.

I believe that any change to m_data->data() would occur through the setData() method only. And we are recreating the m_demux object whenever setData() is called. So, that should take care of any data being moved around, right?

[Note: One exception is that we don't touch the demux object once the demux state is WEBP_DEMUX_DONE. But we could change that to be safe.]

Thoughts?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.