[Webkit-unassigned] [Bug 114298] [WK2][GTK] Adding SpatialNavigation setting to webkit2

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=114298





--- Comment #17 from Danilo Cesar Lemes de Paula <danilo.cesar at collabora.co.uk>  2013-04-15 07:19:13 PST ---
(In reply to comment #16)
> (From update of attachment 197306 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=197306&action=review
> 
> Straight-forward API, looks good to me, cq- because of the wording in the doc
> 
> > Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp:1087
> > +     * Whether to enable Spatial navigation. This feature consists in the ability
> 
> I'd use lower case for spatial here

Spatial Navigation is a feature described with a capital leading letter on webkitgtk+ API, shouldn't it be "Spatial Navigation" instead of "spatial navigation"?
http://webkitgtk.org/reference/webkitgtk/stable/WebKitWebSettings.html#WebKitWebSettings--enable-spatial-navigation

> 
> > Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp:1091
> > +     * there is an element he might be trying to reach towards the right, and if
> 
> s/he/they/

He, in that case, is the user. Also, it's the same text used on webkitgtk+ docs: http://webkitgtk.org/reference/webkitgtk/stable/WebKitWebSettings.html#WebKitWebSettings--enable-spatial-navigation

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.