[Webkit-unassigned] [Bug 114620] win_cmd_shell detection doesn't work under MSYS

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=114620





--- Comment #6 from Jonathan Liu <net147 at gmail.com>  2013-04-15 06:05:10 PST ---
(In reply to comment #2)
> (From update of attachment 198116 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=198116&action=review
> 
> > Tools/qmake/mkspecs/features/default_pre.prf:40
> > +win32:isEmpty(QMAKE_SH): CONFIG += win_cmd_shell
> 
> As far as I know you can have sh.exe in your PATH even in cmd.exe, which this would break.

If you have sh.exe in your PATH, mingw32-make will use sh.exe instead of cmd.exe anyway so the commands in the Makefile generated should be UNIX shell commands.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.