[Webkit-unassigned] [Bug 114620] win_cmd_shell detection doesn't work under MSYS

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=114620





--- Comment #2 from Jocelyn Turcotte <jocelyn.turcotte at digia.com>  2013-04-15 05:46:44 PST ---
(From update of attachment 198116)
View in context: https://bugs.webkit.org/attachment.cgi?id=198116&action=review

> Tools/qmake/mkspecs/features/default_pre.prf:40
> +win32:isEmpty(QMAKE_SH): CONFIG += win_cmd_shell

As far as I know you can have sh.exe in your PATH even in cmd.exe, which this would break.

Maybe this changed but I've spent a lot of hours trying to tweak project files back and forth like this to make sure that QtWebKit could build in both MSYS and cmd.exe to the end concluding that it's just not worth it. Unless you want to commit to maintain this code yourself I would prefer that we stick to only supporting cmd.exe to have one well supported environment on Windows instead of two crappy ones.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.