[Webkit-unassigned] [Bug 114440] Dynamically triggered subframe loads are causing tile churn

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=114440


Andreas Kling <akling at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #198114|review?                     |review+
               Flag|                            |




--- Comment #3 from Andreas Kling <akling at apple.com>  2013-04-15 05:41:41 PST ---
(From update of attachment 198114)
View in context: https://bugs.webkit.org/attachment.cgi?id=198114&action=review

r=me, good catch. I wonder if there are cases where the window resize optimization is too clever and just causing churn.

> Source/WebCore/ChangeLog:8
> +        In some cases we switch in and out of minimal times multiple times during page loading. This

minimal times -> minimal tiles

> Source/WebCore/ChangeLog:9
> +        creates tile churn where we create speculatively tiles and then throw them out. This can be

speculatively -> speculative

> Source/WebCore/ChangeLog:16
> +            tiles while waiting response for the initial requests.

waiting -> awaiting

> Source/WebCore/ChangeLog:18
> +        (WebCore):

<darin>Please remove this useless line. Better yet, please fix the script to stop generating them!</darin>

> Source/WebCore/ChangeLog:28
> +                Only switch into minimal coverage mode once per page load.

Indentation is different here.

> Source/WebCore/rendering/RenderLayerBacking.cpp:226
> +        useMinimalTilesDuringLoading = !frameView->isVisuallyNonEmpty() || (frame->page()->progress()->isLoadProgressing() && !frameView->wasScrolledByUser());

"!frameView->isVisuallyNonEmpty()" :|

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.