[Webkit-unassigned] [Bug 101224] [GTK] Check DOM bindings API compatibility while building

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 15 01:02:09 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=101224





--- Comment #14 from Carlos Garcia Campos <cgarcia at igalia.com>  2013-04-15 01:00:25 PST ---
(In reply to comment #12)
> (From update of attachment 194681 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=194681&action=review
> 
> > Source/WebCore/bindings/scripts/gobject-run-api-break-test:29
> > +if sys.argv[1] == '--reset-results':
> > +    reset_results = True
> > +    from_file = sys.argv[2]
> > +    to_file = sys.argv[3]
> > +else:
> > +    reset_results = False
> > +    from_file = sys.argv[1]
> > +    to_file = sys.argv[2]
> 
> Well, arguments handling is usually done with getopt, I think we should use it here.

A bit overkill when there's only one argument, and this script is not expected to be run by users, but still, I can implement it using argparse.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list