[Webkit-unassigned] [Bug 114508] [meta] Re-engineer StyleBuilder into something maintainable

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Apr 13 08:56:55 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=114508





--- Comment #5 from Antti Koivisto <koivisto at iki.fi>  2013-04-13 08:55:10 PST ---
If it was an easy refactoring it would have been done long time ago. :)

I think this should be done in steps, something like this:

1) rename StyleBuilder -> DeprecatedStyleBuilder
2) create new StyleBuilder (it forwards to DeprecatedStyleBuilder for properties that are still implemented there) 
3) move the giant switch and the related functions from StyleResolver to StyleBuilder
4) move individual properties from DeprecatedStyleBuilder to StyleBuilder until nothing remains
5) delete DeprecatedStyleBuilder

We'll have DeprecatedStyleBuilder and the new StyleBuilder side by side for a while and can verify it is actually better.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list