[Webkit-unassigned] [Bug 114508] [meta] Re-engineer StyleBuilder into something maintainable

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=114508





--- Comment #4 from Dirk Schulze <krit at webkit.org>  2013-04-13 08:02:35 PST ---
(In reply to comment #2)
> Yeah, I think we can instead move the entire switch statement out of the StyleResolver and move it to StyleBuilder.  In fact, we can just repurpose this bug to do that.

I looked a bit in moving applyProperty(CSSPropertyID id, CSSValue* value) from StyleResolver to StyleBuilder.

Doing that would require to
* move some inline and static functions from StyleResolver to StyleBuilder
* make the shared StyleBuilder to a not constant resource (atm: const StaticBuilder& in StyleResolver)
* solve some circular dependencies

All together, it is a quite complex move with a lot of refactoring. Therefore, we should be sure that this is the way to go. Further more, when the template and the switch are in one place, what is the next step?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.