[Webkit-unassigned] [Bug 70592] [EFL][GTK] Share plugin's implementation between EFL and Gtk ports.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=70592


Philippe Normand <pnormand at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #190511|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #17 from Philippe Normand <pnormand at igalia.com>  2013-04-12 12:45:31 PST ---
(From update of attachment 190511)
View in context: https://bugs.webkit.org/attachment.cgi?id=190511&action=review

> Source/WebCore/plugins/x11/PluginViewX11.cpp:78
> +#else

#elif PLATFORM(EFL)

> Source/WebCore/plugins/x11/PluginViewX11.cpp:145
> +#else

Ditto

> Source/WebCore/plugins/x11/PluginViewX11.cpp:680
> +#if PLATFORM(GTK)
> +        *static_cast<uint32_t*>(value) = 2;
> +#else
> +        *static_cast<uint32_t*>(value) = 0;
> +#endif

I don't understand this, I guess it's inherited from the previous PluginView implementation but a comment would be good to have here. Also, mind turning the #else to and #elif ?

> Source/WebCore/plugins/x11/PluginViewX11.cpp:687
> +#else

#elif PLATFORM(EFL)

> Source/WebCore/plugins/x11/PluginViewX11.cpp:994
> +#else

Ditto

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.