[Webkit-unassigned] [Bug 114330] Refactor TextTrack and TextTrackList to make it easier to add audio and video tracks

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=114330


Jer Noble <jer.noble at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #197877|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |




--- Comment #23 from Jer Noble <jer.noble at apple.com>  2013-04-12 12:40:22 PST ---
(From update of attachment 197877)
View in context: https://bugs.webkit.org/attachment.cgi?id=197877&action=review

r+, with nit:

> Source/WebCore/html/track/TextTrack.cpp:574
> +TextTrack* toTextTrack(TrackBase* track)
> +{
> +    ASSERT(track->type() == TrackBase::TextTrack);
> +    return static_cast<TextTrack*>(track);
>  }

Nit: please put the body of this function into the header file, so it can be inlined.

(If you don't have committer rights, just upload a new patch named "Patch for Committing" and either Eric or I will cq+ it.)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.