[Webkit-unassigned] [Bug 112729] [GTK] Web Process crash when the UI process finishes too early

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=112729





--- Comment #9 from Carlos Garcia Campos <cgarcia at igalia.com>  2013-04-12 09:13:12 PST ---
(In reply to comment #8)
> (From update of attachment 193892 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=193892&action=review

Thanks for the review.

> > Source/WebKit2/Platform/CoreIPC/unix/ConnectionUnix.cpp:430
> >  #if PLATFORM(QT)
> >      m_socketNotifier = m_connectionQueue->registerSocketEventHandler(m_socketDescriptor, QSocketNotifier::Read, WTF::bind(&Connection::readyReadHandler, this));
> >  #elif PLATFORM(GTK)
> > -    m_connectionQueue->registerEventSourceHandler(m_socketDescriptor, (G_IO_HUP | G_IO_ERR), WTF::bind(&Connection::connectionDidClose, this));
> > -    m_connectionQueue->registerEventSourceHandler(m_socketDescriptor, G_IO_IN, WTF::bind(&Connection::readyReadHandler, this));
> > +    m_connectionQueue->registerSocketEventHandler(m_socketDescriptor, G_IO_IN, WTF::bind(&Connection::readyReadHandler, this), WTF::bind(&Connection::connectionDidClose, this));
> >  #elif PLATFORM(EFL)
> >      m_connectionQueue->registerSocketEventHandler(m_socketDescriptor, WTF::bind(&Connection::readyReadHandler, this));
> >  #endif
> 
> It's unfortunate that these #ifdefs are here - it feels like something that could be abstracted for ConnectionUnix.

Yeah, but unfortunately is not that easy, the Qt one returns a qt specific object. For GTK+ and EFL it should be easier to share a common interface.

> > Source/WebKit2/Platform/WorkQueue.h:82
> > +    void registerSocketEventHandler(int, int, const Function<void()>&, const Function<void()>&);
> 
> I think you should name both these Function parameters; it's not clear what they do.

Sure.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.