[Webkit-unassigned] [Bug 114506] [=?UTF-8?Q?=E1=BA=81ebkitpy?=] Executive.cpu_count() ignores $NUMBER_OF_PROCESSORS

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=114506





--- Comment #2 from Philippe Normand <pnormand at igalia.com>  2013-04-12 08:50:23 PST ---
(From update of attachment 197852)
View in context: https://bugs.webkit.org/attachment.cgi?id=197852&action=review

> Tools/Scripts/webkitpy/common/system/executive.py:145
> +        if 'NUMBER_OF_PROCESSORS' in os.environ:

This test can be removed. os.environ.get() will return None if the env var is not set, I think.

> Tools/Scripts/webkitpy/common/system/executive.py:150
> +            except:

please explicitely catch ValueError :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.