[Webkit-unassigned] [Bug 112729] [GTK] Web Process crash when the UI process finishes too early

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=112729


Anders Carlsson <andersca at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #193892|review?                     |review+
               Flag|                            |




--- Comment #8 from Anders Carlsson <andersca at apple.com>  2013-04-12 06:48:37 PST ---
(From update of attachment 193892)
View in context: https://bugs.webkit.org/attachment.cgi?id=193892&action=review

> Source/WebKit2/Platform/CoreIPC/unix/ConnectionUnix.cpp:430
>  #if PLATFORM(QT)
>      m_socketNotifier = m_connectionQueue->registerSocketEventHandler(m_socketDescriptor, QSocketNotifier::Read, WTF::bind(&Connection::readyReadHandler, this));
>  #elif PLATFORM(GTK)
> -    m_connectionQueue->registerEventSourceHandler(m_socketDescriptor, (G_IO_HUP | G_IO_ERR), WTF::bind(&Connection::connectionDidClose, this));
> -    m_connectionQueue->registerEventSourceHandler(m_socketDescriptor, G_IO_IN, WTF::bind(&Connection::readyReadHandler, this));
> +    m_connectionQueue->registerSocketEventHandler(m_socketDescriptor, G_IO_IN, WTF::bind(&Connection::readyReadHandler, this), WTF::bind(&Connection::connectionDidClose, this));
>  #elif PLATFORM(EFL)
>      m_connectionQueue->registerSocketEventHandler(m_socketDescriptor, WTF::bind(&Connection::readyReadHandler, this));
>  #endif

It's unfortunate that these #ifdefs are here - it feels like something that could be abstracted for ConnectionUnix.

> Source/WebKit2/Platform/WorkQueue.h:82
> +    void registerSocketEventHandler(int, int, const Function<void()>&, const Function<void()>&);

I think you should name both these Function parameters; it's not clear what they do.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.