[Webkit-unassigned] [Bug 110614] [GTK][WK2] Add document-loaded signal to WebKitWebPage
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Apr 12 00:23:34 PDT 2013
https://bugs.webkit.org/show_bug.cgi?id=110614
--- Comment #31 from Manuel Rego Casasnovas <rego at igalia.com> 2013-04-12 00:21:49 PST ---
(In reply to comment #29)
> (From update of attachment 192433 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=192433&action=review
>
> Ok for WebKit2.
Thanks for the review.
> > Source/WebKit2/WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp:48
> > +enum {
> > + DOCUMENT_LOADED,
> > +
> > + LAST_SIGNAL
> > +};
> > +
> > struct _WebKitWebPagePrivate {
> > WebPage* webPage;
> > };
> >
> > +static guint signals[LAST_SIGNAL] = { 0, };
> > +
>
> This looks like shooting a fly with a canon.
> Any reason not to make this simpler?
As Carlos explained this is the standard way in GNOME.
> > Source/WebKit2/WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp:177
> > + 0 // didLayout
>
> alignment?
What's the problem with alignment here? It's using 4-spaces and style checker didn't complain.
Are you talking about the alignment of the comment regarding the previous lines? Maybe I can add an extra space between "0" and "//".
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list