[Webkit-unassigned] [Bug 110614] [GTK][WK2] Add document-loaded signal to WebKitWebPage

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=110614





--- Comment #30 from Carlos Garcia Campos <cgarcia at igalia.com>  2013-04-12 00:10:37 PST ---
(In reply to comment #29)
> (From update of attachment 192433 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=192433&action=review
> 
> Ok for WebKit2.
> 
> > Source/WebKit2/WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp:48
> > +enum {
> > +    DOCUMENT_LOADED,
> > +
> > +    LAST_SIGNAL
> > +};
> > +
> >  struct _WebKitWebPagePrivate {
> >      WebPage* webPage;
> >  };
> >  
> > +static guint signals[LAST_SIGNAL] = { 0, };
> > +
> 
> This looks like shooting a fly with a canon.
> Any reason not to make this simpler?

This is the "standard" way of implementing signals in GTK+/GNOME. 

> > Source/WebKit2/WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp:177
> > +        0 // didLayout
> 
> alignment?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.