[Webkit-unassigned] [Bug 110614] [GTK][WK2] Add document-loaded signal to WebKitWebPage

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 12 00:05:30 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=110614





--- Comment #29 from Benjamin Poulain <benjamin at webkit.org>  2013-04-12 00:03:44 PST ---
(From update of attachment 192433)
View in context: https://bugs.webkit.org/attachment.cgi?id=192433&action=review

Ok for WebKit2.

> Source/WebKit2/WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp:48
> +enum {
> +    DOCUMENT_LOADED,
> +
> +    LAST_SIGNAL
> +};
> +
>  struct _WebKitWebPagePrivate {
>      WebPage* webPage;
>  };
>  
> +static guint signals[LAST_SIGNAL] = { 0, };
> +

This looks like shooting a fly with a canon.
Any reason not to make this simpler?

> Source/WebKit2/WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp:177
> +        0 // didLayout

alignment?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list