[Webkit-unassigned] [Bug 105451] Unable to place caret in RTL Override Characters by mouse click

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=105451





--- Comment #13 from Yi Shen <max.hong.shen at gmail.com>  2013-04-11 12:39:21 PST ---
Thanks for reviewing. I will fix all you mentioned above.

> > +    bool onlyHasNewlineCharacter() const { return false; }

The only reason I make BidiCharacterRun::onlyHasNewlineCharacter to return false is because a BidiCharacterRun doesn't have enough knowledge to know whether its content contains '\n'. 

Yet BidiCharacterRun never been used in the BidiResolver::recorderRunsFromlevels in our code, it doesn't impact the reordering procedure. Maybe I should rename that function to avoid the confusion. What do you think?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.