[Webkit-unassigned] [Bug 101848] REGRESSION (r133351): Layout issues at bugs.webkit.org, all standard buttons have incorrect text baseline

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=101848





--- Comment #21 from Dave Hyatt <hyatt at apple.com>  2013-04-11 10:25:28 PST ---
Thinking about this some more, I don't think it's a good solution to just flip the rounding blindly. Fundamentally what is going on here is that we need to bias rounding of coordinates based off the characteristics of the coordinate space that you're in.

Snapping should be biased based off whether or not you're LTR or RTL and also on whether or not you're a flipped block.

For example, in horizontal-bt, you want the extra pixel to be on the top when centering. For horizontal-tb, that extra pixel should be on the bottom. Fundamentally the rounding needed to know about the characteristics of the coordinate space.

Same goes for LTR and RTL. When centering LTR or RTL you want to make a rounding decision that biases towards the correct direction.

I think it basically works out as follows:

For a line direction coordinate:
LTR - Floor 0.5. Bias is to push left.
RTL - Ceiling 0.5. Bias is to push right.

For a block direction coordinate:
Normal - Floor 0.5. Bias towards the before side of the block.
Flipped - Ceiling 0.5. Bias towards the after side of the block.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.