[Webkit-unassigned] [Bug 114146] [BlackBerry] Replace getRect() with boundingBox()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=114146


Xan Lopez <xan.lopez at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #196833|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #8 from Xan Lopez <xan.lopez at gmail.com>  2013-04-11 02:08:53 PST ---
(From update of attachment 196833)
View in context: https://bugs.webkit.org/attachment.cgi?id=196833&action=review

r- because we should use different APIs and I think some of the code we are changing is dead.

>>> Source/WebKit/blackberry/Api/WebPage.cpp:2601
>>> +            return view->contentsToWindow(IntRect(node->boundingBox()));
>> 
>> Why do you need the IntRect()?
> 
> I wonder if what we really want here is pixelSnappedBoundingBox() here.

If you read the code this seems to be used to check whether the bounding box intersects with the visible rectangle of another node in ::contextNode. Since the second rectangle is not using a snapped version, I think we should not use it here.

> Source/WebKit/blackberry/Api/WebPage.cpp:5013
>      }

I cannot even find where this code is used. Seems to be dead? If that's so let's just remove it.

>> Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp:1957
>> +    WebCore::IntRect elementRectInRootView = select->document()->view()->contentsToRootView(enclosingIntRect(select->boundingBox()));
> 
> And same here.

Here we should use a pixel snapped version, since it is what Chromium does when calling this API.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.