[Webkit-unassigned] [Bug 114396] [Windows, WinCairo] FeatureDefines.h Overriding Settings in VS Property Sheets

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=114396


Brent Fulgham <bfulgham at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kevino at theolliviers.com,
                   |                            |paroga at paroga.com




--- Comment #1 from Brent Fulgham <bfulgham at webkit.org>  2013-04-10 17:12:07 PST ---
On the Apple Windows target, ENABLE_VIEW_MODE_CSS_MEDIA is included in compiler's command line output, e.g, /D "ENABLE_VIEW_MODE_CSS_MEDIA" because it is marked as "active" in the FeatureDefines.props file.

On the WInCairo build, we have ENABLE_VIEW_MODE_CSS_MEDIA turned off at the moment (in the FeatureDefinesCairo.props file).  Unfortunately, FeatureDefines.h silently flips it back on.

I think the various defines for OS(WINDOWS) in the FeatureDefines.h file that automatically activate certain features should be removed, unless the GTK-Windows, WinCE, wxWidgets, or some other port needs them.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.