[Webkit-unassigned] [Bug 101848] REGRESSION (r133351): Layout issues at bugs.webkit.org, all standard buttons have incorrect text baseline

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=101848





--- Comment #13 from Dave Hyatt <hyatt at apple.com>  2013-04-10 14:28:19 PST ---
Well, I made the mistake of composing a long response in ToT, and it crashed when I hit Commit, so this will be brief.

We just need to patch "centering" layout subsystems to fix the centering issues. Division by 2 without pre-emptive rounding to push up and to the left is wrong, and we just need to fix that. This includes RenderFlexibleBox, RenderDeprecatedFlexibleBox, line-height leading, text-align, table vertical alignment, auto margins on blocks, etc.

For the underline issue that Dan also mentioned, we need to make sure the placement of overline, strike-through and underlines are relative to the rounded position of the drawn text and not just trying to round independently from some source point. That's how errors would creep in for that, so it's easy to fix also.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.