[Webkit-unassigned] [Bug 114298] [WK2][GTK] Adding SpatialNavigation API to webkit2

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=114298





--- Comment #10 from Danilo Cesar Lemes de Paula <danilo.cesar at collabora.co.uk>  2013-04-10 07:21:12 PST ---
(In reply to comment #6)
> (From update of attachment 197156 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=197156&action=review
> 
> Patch looks good to me, thanks! r- because it lacks unit tests. It requires the approval of another GTK+ reviewer and one WebKit2 owner.
> 
> > Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp:1093
> > +     */
> 
> Add Since: 2.2
> 
> > Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp:2695
> > + */
> 
> Since: 2.2 here too
> 
> > Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp:2717
> > + * Returns: %TRUE If HTML5 spatial navigation support is enabled or %FALSE otherwise.
> 
> And here too.
> 
> > Source/WebKit2/UIProcess/API/gtk/WebKitSettings.h:388
> > +webkit_settings_set_enable_spatial_navigation                  (WebKitSettings *settings,
> > +                                                                gboolean enabled);

Fixed the things added above


> 
> Nit: Please line up argument names like all other functions.
I'm following the same rule as the rest of the file

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.