[Webkit-unassigned] [Bug 114298] Adding SpatialNavigation API to webkit2

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=114298


Carlos Garcia Campos <cgarcia at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #197156|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #6 from Carlos Garcia Campos <cgarcia at igalia.com>  2013-04-10 06:05:04 PST ---
(From update of attachment 197156)
View in context: https://bugs.webkit.org/attachment.cgi?id=197156&action=review

Patch looks good to me, thanks! r- because it lacks unit tests. It requires the approval of another GTK+ reviewer and one WebKit2 owner.

> Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp:1093
> +     */

Add Since: 2.2

> Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp:2695
> + */

Since: 2.2 here too

> Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp:2717
> + * Returns: %TRUE If HTML5 spatial navigation support is enabled or %FALSE otherwise.

And here too.

> Source/WebKit2/UIProcess/API/gtk/WebKitSettings.h:388
> +webkit_settings_set_enable_spatial_navigation                  (WebKitSettings *settings,
> +                                                                gboolean enabled);

Nit: Please line up argument names like all other functions.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.