[Webkit-unassigned] [Bug 113680] [css3-text] Parsing -webkit-hanging value for text-indent from css3-text

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=113680





--- Comment #6 from Jaehun Lim <ljaehun.lim at samsung.com>  2013-04-09 19:39:16 PST ---
(From update of attachment 196096)
View in context: https://bugs.webkit.org/attachment.cgi?id=196096&action=review

Thanks for your comments.

>> Source/WebCore/css/CSSComputedStyleDeclaration.cpp:2197
>> +            // getPropertyCSSValue() returns CSSValue.
> 
> perceantage -> percentage

Fixed.

>> Source/WebCore/css/StyleBuilder.cpp:2049
>> +        TextIndentType hangingValue = TextIndentNormal;
> 
> These are badly named, as they refer to one of two possible values in both cases.
> I'd suggest something like:
> 
> TextIndentLine textIndentLineValue = RenderStyle::initialTextIndentLine();
> TextIndentType textIndentTypeValue = RenderStyle::initialTextIndentType();
> 
> That way you also avoid repeating the initial values.

Fixed to use init functions and change names.

>> Source/WebCore/rendering/style/StyleRareInheritedData.h:105
>> +    unsigned m_textIndentType : 1; // TextIndentHanging
> 
> TextIndentHanging -> TextIndentType

Fixed with TextIndentEachLine -> TextIndentLine

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.