[Webkit-unassigned] [Bug 113853] Add API in QWebSettings for setting the CSS media type
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Apr 9 02:09:12 PDT 2013
https://bugs.webkit.org/show_bug.cgi?id=113853
--- Comment #16 from Jose Lejin PJ <jose.lejin at gmail.com> 2013-04-09 02:07:26 PST ---
(In reply to comment #15)
> (From update of attachment 196999 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=196999&action=review
>
> This is starting to look pretty clean, but as stated in Comment #12, we needs a test for this in Source/WebKit/qt/tests/qwebpage/tst_qwebpage.cpp. Testing this setting both thouth a non-global and through globalSettings() would be great.
>
> > Source/WebKit/qt/ChangeLog:3
> > + Add API in QWebSettings for setting the CSS media type
>
> For Qt specific bugs, we add the "[Qt] " prefix in front of our changelog headlines.
>
> > Source/WebKit/qt/Api/qwebsettings.cpp:938
> > + Sets the CSS media type.
>
> Please provide enough documentation for people to understand how this feature work.
> The documentation could match the one for mediaStyle and setMediaStyle in Source/WebKit/mac/WebView/WebView.h.
>
> Specifically, it should state that setting this to a null QString will revert to the default one, and that cssMediaType will only return the value set through setCSSMediaType and not the one used internally.
>
> > Source/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp:1572
> > + // If type is null try to get value from QWebSettings::globalSettings()
> > + if (type.isNull())
> > + type = QWebSettings::globalSettings()->cssMediaType();
>
> This case should already be handled by your code in QWebSettings::apply(). If not, something is wrong.
Thanks for review. I will add needed test cases and documentation.
Yes.. QWebSettings::apply() is taking care of returning proper media type set by globalSettings. I will remove this in patch.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list