[Webkit-unassigned] [Bug 110926] Can't use fastGetAttribute with WebCore::HTMLNames::classAttr when element is a SVGStyledElement

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 9 01:50:56 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=110926





--- Comment #43 from Eric Seidel <eric at webkit.org>  2013-04-09 01:49:09 PST ---
(In reply to comment #42)
> (From update of attachment 196067 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=196067&action=review
> > Have we done performance tests on the difference in performance from calling getAttribute vs. "if (isSVG) getAttribute() else fastGetAttribute()"? If it’s not a measurable difference then we should consider that implementation.

getAttribute() is definitely much slower than fastGetAttribute, but you already know that.  :)  I'm not sure exactly what you're suggesting as an alternative here.  Are you suggesting that we send all SVG attribute accesses down the getAttribute path?  That seems overly conservative, if true?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list