[Webkit-unassigned] [Bug 114240] Hopefully helpful comments for some String methods

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 9 00:00:18 PDT 2013


--- Comment #3 from Victor Costan <costan at gmail.com>  2013-04-08 23:58:32 PST ---
Thank you for the quick feedback, Geoffrey!

When I read the code, I understood what it takes to make it crash. I didn't immediately understand that the recommended way of working on a String's characters is to have separate branches conditioned on is8Bit(). I wrote my conclusion as the comment for characters(). Should I copy it / point to it in the comments for characters{8, 16}() ?

Would it be better to change is8Bit() to return true for null strings?

Thank you!

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list