[Webkit-unassigned] [Bug 104807] Adds support for fromCharCode intrinsic

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=104807


Filip Pizlo <fpizlo at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #196957|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #22 from Filip Pizlo <fpizlo at apple.com>  2013-04-08 14:45:25 PST ---
(From update of attachment 196957)
View in context: https://bugs.webkit.org/attachment.cgi?id=196957&action=review

LGTM except for those minor fixes.

> Source/JavaScriptCore/dfg/DFGAbstractState.cpp:865
> +        node->setCanExit(true);

Not needed.

> Source/JavaScriptCore/dfg/DFGAbstractState.cpp:866
> +        forNode(node->child1()).filter(SpecInt32);

Not needed.

> Source/JavaScriptCore/dfg/DFGFixupPhase.cpp:352
> +            setUseKindAndUnboxIfProfitable<Int32Use>(node->child1());

The reason why you don't need the filter() and setCanExit() in AbstractState is that AbstractState::executeEdges() takes care of this based on Int32Use.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.