[Webkit-unassigned] [Bug 113965] Add interfaces and stubs for audio and video tracks

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=113965





--- Comment #22 from Jer Noble <jer.noble at apple.com>  2013-04-08 13:55:39 PST ---
(In reply to comment #21)
> When making the template for TrackListBase<T>, should I:
> 
>   * Include templated member functions in TrackListBase.h
> 
> Or
> 
>   * Define TrackListBase<AudioTrack>, TrackListBase<TextTrack> and TrackListBase<VideoTrack> at the end of TrackListBase.cpp
> 
> There's not a lot of templated classes in WebKit so I'm not sure what the preferred version is.

Please don't use a templated base class. (In reply to comment #21)
> When making the template for TrackListBase<T>, should I:
> 
>   * Include templated member functions in TrackListBase.h
> 
> Or
> 
>   * Define TrackListBase<AudioTrack>, TrackListBase<TextTrack> and TrackListBase<VideoTrack> at the end of TrackListBase.cpp
> 
> There's not a lot of templated classes in WebKit so I'm not sure what the preferred version is.

While I haven't seen your proposed templated base class yet, it seems like it will be much more complicated than it has to be.  Why not just make a (non templated) TrackListBase, where all the methods take TrackBase* arguments, add specialized {Video,Audio,Text}TrackList classes with non-virtual index accessors, and add "ASSERT(type() == VideoTrack)" checks where necessary?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.