[Webkit-unassigned] [Bug 113853] Add API in QWebSettings for setting the CSS media type

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=113853





--- Comment #12 from Jocelyn Turcotte <jocelyn.turcotte at digia.com>  2013-04-08 06:46:18 PST ---
(From update of attachment 196845)
View in context: https://bugs.webkit.org/attachment.cgi?id=196845&action=review

> Source/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp:1568
> +        mediaType = m_frame->settings()->mediaTypeOverride();

Please don't do that, have a separate boolean in QWebSettingsPrivate.
WebCore::Settings::mediaTypeOverride() seems to be used by testing code and this would be mixing layers that are not designed in that way.
This also needs to work with QWebSettings::globalSettings(), which wouldn't in this case.

Also, please add tests for this feature in Source/WebKit/qt/tests/qwebpage/tst_qwebpage.cpp

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.