[Webkit-unassigned] [Bug 113853] Add API in QWebSettings for setting the CSS media type

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=113853


Jocelyn Turcotte <jocelyn.turcotte at digia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #196455|review?                     |review-
               Flag|                            |




--- Comment #7 from Jocelyn Turcotte <jocelyn.turcotte at digia.com>  2013-04-08 02:51:52 PST ---
(From update of attachment 196455)
Did you test this well?
By reading the code it seems like this only applies to the current FrameView (which is only used for the currently navigated page).
If you click a link to navigate to a second page, it feels like this setting won't be applied unless you call setMediaTypeOverride again.

A safer way to implement this would be to do like setMediaStyle is implemented in Source/WebKit/mac/WebView/WebView.mm.
It could still live in QWebSettings, but instead of forwarding the value to WebCore::Settings, it would be fetched by our implementation of FrameLoaderClientQt::overrideMediaType in Source/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.