[Webkit-unassigned] [Bug 114146] [BlackBerry] Replace getRect() with boundingBox()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=114146





--- Comment #7 from Carlos Garcia Campos <cgarcia at igalia.com>  2013-04-08 01:25:31 PST ---
(From update of attachment 196833)
View in context: https://bugs.webkit.org/attachment.cgi?id=196833&action=review

>> Source/WebKit/blackberry/Api/WebPage.cpp:2601
>> +            return view->contentsToWindow(IntRect(node->boundingBox()));
> 
> Why do you need the IntRect()?

I wonder if what we really want here is pixelSnappedBoundingBox() here.

> Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp:1957
> -    WebCore::IntRect elementRectInRootView = select->document()->view()->contentsToRootView(enclosingIntRect(select->getRect()));
> +    WebCore::IntRect elementRectInRootView = select->document()->view()->contentsToRootView(enclosingIntRect(select->boundingBox()));

And same here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.