[Webkit-unassigned] [Bug 106198] PreloadScanner preloads external CSS with non-matching media attribute

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=106198





--- Comment #12 from Eric Seidel <eric at webkit.org>  2013-04-06 15:11:51 PST ---
(From update of attachment 196676)
View in context: https://bugs.webkit.org/attachment.cgi?id=196676&action=review

> Source/WebCore/html/parser/HTMLResourcePreloader.cpp:84
> +    if(!preload->media().isEmpty() && !mediaAttributeMatches(m_document->frame(), m_document->renderer()->style(), preload->media()))

missing a space betwen if and (

> Source/WebCore/html/parser/HTMLResourcePreloader.h:36
> +    static PassOwnPtr<PreloadRequest> create(const String& initiator, const String& resourceURL, const KURL& baseURL, CachedResource::Type resourceType, const String& mediaAttr="")

I've not seen const String& used with defaut values in WebKit before...

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.