[Webkit-unassigned] [Bug 110414] CMake should not require build target

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Apr 6 04:51:02 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=110414





--- Comment #3 from Patrick R. Gansterer <paroga at paroga.com>  2013-04-06 04:49:16 PST ---
(From update of attachment 189431)
View in context: https://bugs.webkit.org/attachment.cgi?id=189431&action=review

> CMakeLists.txt:12
> -string(TOLOWER ${CMAKE_BUILD_TYPE} CMAKE_BUILD_TYPE)
> +if (CMAKE_BUILD_TYPE)
> +    string(TOLOWER ${CMAKE_BUILD_TYPE} CMAKE_BUILD_TYPE)
> +endif ()

IMHO we should only remove the TOLOWER and replace "debug" with "Debug" in the other CMake files

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list