[Webkit-unassigned] [Bug 13709] Table border doesn't show up

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=13709





--- Comment #44 from Suchit Agrawal <a.suchit at samsung.com>  2013-04-05 09:57:29 PST ---
> (From update of attachment 196486 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=196486&action=review
> 
> > Source/WebCore/css/StyleBuilder.cpp:625
> >  enum ComputeLengthSVGZoom {SVGZoomDisabled = 0, SVGZoomEnabled};
> >  template <typename T,
> >            T (RenderStyle::*getterFunction)() const,
> >            void (RenderStyle::*setterFunction)(T),
> >            T (*initialFunction)(),
> >            ComputeLengthNormal normalEnabled = NormalDisabled,
> > -          ComputeLengthThickness thicknessEnabled = ThicknessDisabled,
> >            ComputeLengthSVGZoom svgZoomEnabled = SVGZoomDisabled>
> > -class ApplyPropertyComputeLength {
> > +class ApplyPropertyComputeTextSpacing {
> 
> - text spacing properties are always int so T can be dropped
> - svgZoomEnabled and normalEnabled are always true for text spacing properties. Those can be dropped.
> 
Changed as per comments.

> 
> > Source/WebCore/css/StyleBuilder.cpp:669
> > +template <typename T,
> > +          T (RenderStyle::*getterFunction)() const,
> > +          void (RenderStyle::*setterFunction)(T),
> > +          T (*initialFunction)()>
> > +class ApplyPropertyComputeTransformOriginZ {
> 
> This is always float. No need for T.
> 
Changed as per comments.

> 
> > Source/WebCore/css/StyleBuilder.cpp:2200
> > -    setPropertyHandler(CSSPropertyWebkitBorderHorizontalSpacing, ApplyPropertyComputeLength<short, &RenderStyle::horizontalBorderSpacing, &RenderStyle::setHorizontalBorderSpacing, &RenderStyle::initialHorizontalBorderSpacing>::createHandler());
> > +    setPropertyHandler(CSSPropertyWebkitBorderHorizontalSpacing, ApplyPropertyComputeTextSpacing<short, &RenderStyle::horizontalBorderSpacing, &RenderStyle::setHorizontalBorderSpacing, &RenderStyle::initialHorizontalBorderSpacing>::createHandler());
> >      setPropertyHandler(CSSPropertyWebkitBorderImage, ApplyPropertyBorderImage<BorderImage, CSSPropertyWebkitBorderImage, &RenderStyle::borderImage, &RenderStyle::setBorderImage>::createHandler());
> > -    setPropertyHandler(CSSPropertyWebkitBorderVerticalSpacing, ApplyPropertyComputeLength<short, &RenderStyle::verticalBorderSpacing, &RenderStyle::setVerticalBorderSpacing, &RenderStyle::initialVerticalBorderSpacing>::createHandler());
> > +    setPropertyHandler(CSSPropertyWebkitBorderVerticalSpacing, ApplyPropertyComputeTextSpacing<short, &RenderStyle::verticalBorderSpacing, &RenderStyle::setVerticalBorderSpacing, &RenderStyle::initialVerticalBorderSpacing>::createHandler());
> 
Changed as per comments.

> 
> These are not text spacing properties so shouldn't use ApplyPropertyComputeTextSpacing. I suspect they can just use ApplyPropertyComputeBorderWidth with the new rounding.
> 
> > Source/WebCore/css/StyleBuilder.cpp:2221
> > -    setPropertyHandler(CSSPropertyWebkitColumnRuleWidth, ApplyPropertyComputeLength<unsigned short, &RenderStyle::columnRuleWidth, &RenderStyle::setColumnRuleWidth, &RenderStyle::initialColumnRuleWidth, NormalDisabled, ThicknessEnabled>::createHandler());
> > +    setPropertyHandler(CSSPropertyWebkitColumnRuleWidth, ApplyPropertyComputeBorderWidth<unsigned short, &RenderStyle::columnRuleWidth, &RenderStyle::setColumnRuleWidth, &RenderStyle::initialColumnRuleWidth, ThicknessEnabled>::createHandler());
> 
> This too.
> 
No change required.

> 
> > LayoutTests/fast/borders/border-width-less-then-a-unit-of-pt.html:38
> > +<div style="border-width:.8pt">There should be a border around this text.</div>
> > +<br/>
> > +<table style="border-width:1.3pt">
> > +    <tr>
> > +    <td>Table border should present.</td>
> > +    </tr>
> > +</table>
> 
> The tests should cover all properties where behavior changes (outline-width, etc).
> 
Test case based on border width, outline-offset, outline-width, border spacing and column rule width properties.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.