[Webkit-unassigned] [Bug 85066] [GTK] TestWebKitAPI/WebKit2/TestMouseMoveAfterCrash is flaky

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=85066





--- Comment #4 from Carlos Garcia Campos <cgarcia at igalia.com>  2013-04-05 08:44:36 PST ---
(In reply to comment #3)
> Created an attachment (id=196632)
 --> (https://bugs.webkit.org/attachment.cgi?id=196632&action=review) [details]
> Patch for WorkQueue and ProcessLauncher
> 
> Fixes for "bad file descriptor/socket operation on non-socket descriptor" crashes in WorkQueueGtk.cpp and ProcessLauncher.cpp. Maybe they should go on a separate bug.
> 
> From the commit message:
> 
>     - Avoid calling connectionDidClose() twice.
> 
>     From g_source_create_source:
> 
>     "It is meaningless to specify G_IO_ERR or G_IO_HUP in condition; these
>     conditions will always be reported output if they are true."
>
>     As readyReadHandler() will be called anyway for G_IO_HUP e G_IO_ERR, let
>     it in charge of calling connectionDidClose instead of adding another
>     event source, just like EFL and Qt does.
> 
>     - Check the status of m_cancellable().
> 
>     EventSource::cancel() cancels m_cancellable, which triggers this
>     source with the current condition. A check for the cancellable status
>     is needed to check whether it was cancelled or not.

This is properly fixed in this bug where I reworked the WorQueue implementation:

https://bugs.webkit.org/show_bug.cgi?id=112729

Patch has been reviewed but still waiting for a WebKit2 owner to be approved.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.