[Webkit-unassigned] [Bug 13709] Table border doesn't show up

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=13709


Antti Koivisto <koivisto at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #196129|review?                     |review-
               Flag|                            |




--- Comment #32 from Antti Koivisto <koivisto at iki.fi>  2013-04-04 02:59:37 PST ---
(From update of attachment 196129)
View in context: https://bugs.webkit.org/attachment.cgi?id=196129&action=review

> Source/WebCore/css/StyleBuilder.cpp:586
> +template <> unsigned computeLength<unsigned>(RenderStyle* style, RenderStyle* rootStyle, float zoom, CSSPrimitiveValue* primitiveValue)

So ApplyPropertyComputeLength<unsigned,... version is only used for border properties, making this special rounding behavior border specific. This is a very indirect and confusing way of getting border specific behavior.

I think it would be better to refactor this a bit. The current ApplyPropertyComputeLength could be replaced with several simpler versions

ApplyPropertyComputeBorderWidth (for border, outline and similar properties. this would have your new rounding behavior)
ApplyPropertyComputeTextSpacing (for word and letter-spacing, only case that has svgZoomEnabled)
ApplyPropertyComputeTransformOriginZ (this is the only float case and seems to want the rounding behavior only. maybe not even needed.)

Each of these can be much simpler and understandable than the current overly generic type. Most of the template parameters can be removed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.