[Webkit-unassigned] [Bug 113641] [EFL] --minimal build fails
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Apr 3 14:24:32 PDT 2013
https://bugs.webkit.org/show_bug.cgi?id=113641
--- Comment #18 from Ed Bartosh <bartosh at gmail.com> 2013-04-03 14:22:43 PST ---
> Are you sure that HAVE(ACCESSIBILITY) defined for all these ports? Also do these ports all allow turning ACCESSIBILITY off ? Not all configuration options are valid for all ports.
I thought it would break builds for those platforms if it's not defined.
grep -r 'HAVE(ACCESSIBILITY)' Source/* |grep 'chromium\|mac\|gtk' shows that it's used in all 3 platforms in question.
> > Source/WebCore/editing/chromium/FrameSelectionChromium.cpp:39
> > +#if HAVE(ACCESSIBILITY)
>
> This should not be necessary as this is file is not used for EFL.
Valid point. I'll updated the patch.
Thank you for review!
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list