[Webkit-unassigned] [Bug 108897] [Cairo] Canvas-shadow behavior is not being as expected

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=108897





--- Comment #25 from Martin Robinson <mrobinson at webkit.org>  2013-04-03 11:06:34 PST ---
(In reply to comment #23)
> Question:. Why should the extend mode be "CAIRO_EXTEND_NONE"?
> Ans: As described in the cairo manual,
> http://cairographics.org/manual/cairo-cairo-pattern-t.html#cairo-extend-t :
> 
> "The default extend mode is CAIRO_EXTEND_NONE for surface patterns and CAIRO_EXTEND_PAD for gradient patterns."
> 
> In the function PlatformContextCairo::drawSurfaceToContext(), a pattern is being created from the source surface and this pattern is drawn onto the destination context. There is no gradient involved. Hence the extend mode for filling the pattern should be "CAIRO_EXTEND_NONE".

Not sure I understand this part of your explanation. The Cairo documentation you point to talks about the default extend mode, but in this code we are overriding the default. We should be considering what the correct behavior of WebKit is here, not merely duplicating the default settings in Cairo. Perhaps I've misinterpreted what you said though...

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.