[Webkit-unassigned] [Bug 110314] [GTK][AC] Implement matrix keyframe animations with clutter ac backend

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=110314


Gustavo Noronha (kov) <gns at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #189267|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #4 from Gustavo Noronha (kov) <gns at gnome.org>  2013-04-02 06:02:02 PST ---
(From update of attachment 189267)
View in context: https://bugs.webkit.org/attachment.cgi?id=189267&action=review

> Source/WebCore/platform/graphics/clutter/PlatformClutterAnimation.cpp:540
> +    GOwnPtr<GValue> keyValues(g_new0(GValue, nKeyframes));

This will go wrong. GOwnPtr will expect a single GValue pointer here but you want an array. We either need a GOwnArrayPtr like the one used for OwnPtr above, or manual handling of this array. I suggest using manual handling.

> Source/WebCore/platform/graphics/clutter/PlatformClutterAnimation.cpp:559
> +    for (unsigned i = 0; i < nKeyframes; ++i)
> +        g_value_unset(&keyValues.get()[i]);
> +}

Then here you'll have to free all of the values instead of unsetting.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.