[Webkit-unassigned] [Bug 113318] [GTK][AC] Support preserves3D css property for clutter ac backend.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 2 05:45:35 PDT 2013


Gustavo Noronha (kov) <gns at gnome.org> changed:

           What    |Removed                     |Added
 Attachment #196080|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |

--- Comment #12 from Gustavo Noronha (kov) <gns at gnome.org>  2013-04-02 05:43:47 PST ---
(From update of attachment 196080)
View in context: https://bugs.webkit.org/attachment.cgi?id=196080&action=review

cq- because of the suggestion

> Source/WebCore/platform/graphics/clutter/GraphicsLayerClutter.cpp:707
> -        newSublayers.append(childLayer);
> +        graphicsLayerActorSetFlatten(childLayer, !(preserves3D() || currentChild->preserves3D()));

> "If the preserve3D() of this layer returns true, itself and its children should not be flattened" is better to me.
> But I don't mind removing the comment if it causes that you're confused. :p

The thing is that comment you suggest does not describe what the code is doing, do you agree with that? What the code does is set flatten to true on the child layer if both the current layer and the child do *not* preserve 3D. So I think you could say this:

"The child layer only preserves 3D if both itself and its parent have preserves3D set."

But feel free to omit the comment, I think the code speaks for itself.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list