[Webkit-unassigned] [Bug 110717] [EFL] Consolidate defaults for feature flags

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=110717





--- Comment #16 from Daniel Bates <dbates at webkit.org>  2013-04-01 22:36:58 PST ---
(From update of attachment 193455)
View in context: https://bugs.webkit.org/attachment.cgi?id=193455&action=review

> Tools/Scripts/build-webkit:93
> +    my $port = "EFL";

Do you anticipate making use of this local variable in the near future? Otherwise, I suggest we inline its value into the definition of $portDefine (below) since that is the only expression that references $port inside this if-block.

> Tools/Scripts/build-webkit:98
> +    # hash table with macro names and values

This comment doesn't add much value as it states what the code below does. I suggest you either elaborate further or remove this comment.

> Tools/Scripts/build-webkit:107
> +            $_->{default} = $FeatureDefaults{$_->{define}};

The variable name $FeatureDefaults should be written in CamelCase and begin with a lowercase letter.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.