[Webkit-unassigned] [Bug 113689] REGRESSION (r147241): Failures in three IDB layout tests on GTK

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 1 12:55:36 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=113689





--- Comment #3 from Michael Pruett <michael at 68k.org>  2013-04-01 12:53:47 PST ---
(In reply to comment #2)
> Sorry about that. We need to try and get ScriptState and SSV better aligned *internally* in the V8 binding and between V8 and and JSC.
> 
> Some vague notes in https://bugs.webkit.org/show_bug.cgi?id=113091
> 
> Apologies for not anticipating this failure. :(

The JSC implementation of ScriptValue::serialize(ScriptState*, MessagePortArray*, ArrayBufferArray*, bool&), added in r116763, was flawed in that it called the specialized SerializedScriptValue::create(JSContextRef, JSValueRef, MessagePortArray*, ArrayBufferArray*, JSValueRef*).

This variant of SerializedScriptValue::create(), which returns the exception thrown in its final parameter and clears the exception on the JSContextRef, was intended for use in the WebKit layer and not in WebCore bindings (r51256).

The fix in r147241 exposed this formerly latent error.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list