[Webkit-unassigned] [Bug 115401] New: Fix handling of 'inherit' and 'initial' for grid lines

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 30 00:56:48 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=115401

           Summary: Fix handling of 'inherit' and 'initial' for grid lines
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Layout and Rendering
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: rniwa at webkit.org
                CC: hyatt at apple.com, jchaffraix at webkit.org,
                    simon.fraser at apple.com, dino at apple.com


We should consider back porting https://chromium.googlesource.com/chromium/blink/+/5d3509453888658290265b2ca96b569862ea396b

Fix handling of 'inherit' and 'initial' for grid lines

'initial' and 'inherit' are always allowed values for CSS properties.
As the CSSParser handles them automatically, those 2 values were never
taken care of in StyleResolver, leading to ASSERTs triggering.

While touching this code, renamed the RenderStyle grid line accessors
as it shouldn't ambiguous to whom they apply.

BUG=234198
TESTS=fast/css-grid-layout/grid-item-column-row-get-set.html
      fast/css-grid-layout/grid-item-end-after-get-set.html
      fast/css-grid-layout/grid-item-start-before-get-set.html

Review URL: https://chromiumcodereview.appspot.com/14493016

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list