[Webkit-unassigned] [Bug 115352] Make sure gstreamer source element is thread-safe

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=115352





--- Comment #7 from Andre Moreira Magalhaes <andrunko at gmail.com>  2013-04-29 08:50:31 PST ---
(In reply to comment #6)
> (In reply to comment #5)
> > (In reply to comment #3)
> > > I suppose this is related with some adaptive streaming scenario?
> > > 
> > > We plan soon to switch the http source element to webkit+http scheme btw, bug 108088
> > 
> > Yes, the threading issues were found when testing DASH and MSS support for gstreamer which uses gst-plugins-bad GstUriDownloader which in turn uses the webkit source element when creating http:// elements with gst_element_make_from_uri. GstUriDownloader uses its own threads to download data which leads to some races when using the webkit gst source element.
> 
> This is bad news if the element is interacting with WebCore at all. Interactions with WebCore should all be on the main thread (the WebCore thread) and mutexes around critical sections in the element are not enough to prevent badness.

This patch makes sure all WebCore methods are called from the main thread using g_timeout_add_full (assuming the glib main thread is the same as WebCore main thread for webkit-gtk). This isn't true without this patch though.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.