[Webkit-unassigned] [Bug 114950] DOMFileSystemBase: fix multiple definitions in the BlackBerry port

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=114950


Xan Lopez <xan.lopez at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |xan.lopez at gmail.com




--- Comment #6 from Xan Lopez <xan.lopez at gmail.com>  2013-04-29 00:29:01 PST ---
(In reply to comment #5)
> What The Fuck?
> 
> This should have:
> -Justification on why you did not make an abstraction instead.
> -Justification for using different implementation.
> 
> Adding platform #ifdef anywhere at random places in WebCore is not okay, we are trying to remove them. Please explain.

The file already had #ifdefs for Chromium, which were removed recently with the removal of the Chromium code. It just so happens that the BB port was also using this feature, but the #ifdefs were not upstreamed. So the justification is that in general adding an extra #ifdef when there's already one is not a big deal, but we can open another bug to improve the code.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.