[Webkit-unassigned] [Bug 115335] [Windows] Building with ENABLE_GLOBAL_FASTMALLOC_NEW causes QuickTime link failure
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Apr 28 21:21:26 PDT 2013
https://bugs.webkit.org/show_bug.cgi?id=115335
--- Comment #1 from Brent Fulgham <bfulgham at webkit.org> 2013-04-28 21:19:47 PST ---
Stubbing out the fastMalloc calls with ::malloc and ::free gives a clean, working build. It also prevents the create-lots-of-workers crash:
Index: WTF/wtf/FastMalloc.h
===================================================================
--- WTF/wtf/FastMalloc.h (revision 148591)
+++ WTF/wtf/FastMalloc.h (working copy)
@@ -264,14 +264,14 @@
#pragma warning(push)
#pragma warning(disable: 4290) // Disable the C++ exception specification ignored warning.
#endif
-WTF_PRIVATE_INLINE void* operator new(size_t size) throw (std::bad_alloc) { return fastMalloc(size); }
-WTF_PRIVATE_INLINE void* operator new(size_t size, const std::nothrow_t&) throw() { return fastMalloc(size); }
-WTF_PRIVATE_INLINE void operator delete(void* p) throw() { fastFree(p); }
-WTF_PRIVATE_INLINE void operator delete(void* p, const std::nothrow_t&) throw() { fastFree(p); }
-WTF_PRIVATE_INLINE void* operator new[](size_t size) throw (std::bad_alloc) { return fastMalloc(size); }
-WTF_PRIVATE_INLINE void* operator new[](size_t size, const std::nothrow_t&) throw() { return fastMalloc(size); }
-WTF_PRIVATE_INLINE void operator delete[](void* p) throw() { fastFree(p); }
-WTF_PRIVATE_INLINE void operator delete[](void* p, const std::nothrow_t&) throw() { fastFree(p); }
+WTF_PRIVATE_INLINE void* operator new(size_t size) throw (std::bad_alloc) { return ::malloc(size); /*fastMalloc(size);*/ }
+WTF_PRIVATE_INLINE void* operator new(size_t size, const std::nothrow_t&) throw() { return ::malloc(size); /*fastMalloc(size);*/ }
+WTF_PRIVATE_INLINE void operator delete(void* p) throw() { ::free(p); /*fastFree(p);*/ }
+WTF_PRIVATE_INLINE void operator delete(void* p, const std::nothrow_t&) throw() { ::free(p); /*fastFree(p);*/ }
+WTF_PRIVATE_INLINE void* operator new[](size_t size) throw (std::bad_alloc) { return ::malloc(size); /*fastMalloc(size);*/ }
+WTF_PRIVATE_INLINE void* operator new[](size_t size, const std::nothrow_t&) throw() { return ::malloc(size); /*fastMalloc(size);*/ }
+WTF_PRIVATE_INLINE void operator delete[](void* p) throw() { ::free(p); /*fastFree(p);*/ }
+WTF_PRIVATE_INLINE void operator delete[](void* p, const std::nothrow_t&) throw() { ::free(p); /*fastFree(p);*/ }
#if COMPILER(MSVC)
#pragma warning(pop)
#endif
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list