[Webkit-unassigned] [Bug 115285] New: [webkitpy] suggest-nominations doesn't count all qualified patches

Fri Apr 26 16:14:33 PDT 2013

https://bugs.webkit.org/show_bug.cgi?id=115285

           Summary: [webkitpy] suggest-nominations doesn't count all
                    qualified patches
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: glenn at skynav.com
                CC: mjs at apple.com, sam at webkit.org, dpranke at chromium.org,
                    rniwa at webkit.org

The suggest-nominations command does not count reviewed patches for contributors after they become a contributor. In particular, the current code only counts those patches which contain a "Patch by" line, which doesn't hold for contributors after they become committers. As a result of this, the patch count for committers are undercounted for the purpose of nominating them as reviewer.

In addition, the command nominates reviewers that have not yet been confirmed as committers.

The proposed patch resolves these problems by:

(1) counting all qualified reviewed patches for nominations;
(2) nominating reviewers only if they are existing committers;

In addition, the proposed patch adds a number of useful options to obtain more information about analyzed commits:

--show-skipped-commits

show skipped commits except those that are explicitly marked as unreviewed

--show-skipped-unreviewed-commits

show skipped commits including those explicitly marked as unreviewed

--show-unreviewed-commits

show unmarked, unreviewed, non-gardening commits by committer/reviewer, including counts; when using this option, no nominations are output

--show-unreviewed-commits-for

used instead of --show-unreviewed-commits to show results for specific contributors

--show-unreviewed-commits-revisions

used with --show-unreviewed-commits or --show-unreviewed-commits-for in order to add list of revisions

--record-marked-unreviewed-commits

used with --show-unreviewed-commits or --show-unreviewed-commits-for in order to count marked, unreviewed, non-gardening commits which are normally not counted; a commit is marked as unreviewed by including 'Unreviewed' in the change log;

--record-gardening-unreviewed-commits

used with --record-marked-unreviewed-commits in order to additionally counted marked, unreviewed commits that include "Gardening" or "gardening";

Following is an example of using --show-unreviewed-commits (with post facto sorting of results):

webkit-patch suggest-nominations --show-unreviewed-commits
UNREVIEWED COMMITS: [R] (277) Ryosuke Niwa
UNREVIEWED COMMITS: [R] (100) Simon Fraser
UNREVIEWED COMMITS: [R] ( 95) Kent Tamura
UNREVIEWED COMMITS: [R] ( 64) Dimitri Glazkov
UNREVIEWED COMMITS: [R] ( 63) Ojan Vafai
UNREVIEWED COMMITS: [R] ( 58) Jessie Berlin
UNREVIEWED COMMITS: [R] ( 53) Geoffrey Garen
UNREVIEWED COMMITS: [R] ( 47) Anders Carlsson
UNREVIEWED COMMITS: [R] ( 45) Pavel Feldman
UNREVIEWED COMMITS: [R] ( 44) David Kilzer
UNREVIEWED COMMITS: [R] ( 43) Alexey Proskuryakov
UNREVIEWED COMMITS: [R] ( 40) Sam Weinig
UNREVIEWED COMMITS: [R] ( 36) Adam Barth
UNREVIEWED COMMITS: [R] ( 35) James Robinson
UNREVIEWED COMMITS: [R] ( 31) Oliver Hunt
UNREVIEWED COMMITS: [R] ( 25) Dan Bernstein
UNREVIEWED COMMITS: [R] ( 23) Csaba Osztrogonác
UNREVIEWED COMMITS: [R] ( 21) Martin Robinson
UNREVIEWED COMMITS: [R] ( 20) Mark Rowe
UNREVIEWED COMMITS: [R] ( 19) Beth Dakin
UNREVIEWED COMMITS: [R] ( 16) Dean Jackson
UNREVIEWED COMMITS: [R] ( 14) Andreas Kling
UNREVIEWED COMMITS: [R] ( 12) Andy Estes
UNREVIEWED COMMITS: [R] ( 10) Benjamin Poulain
UNREVIEWED COMMITS: [R] (  9) Levi Weintraub
UNREVIEWED COMMITS: [R] (  9) Daniel Bates
UNREVIEWED COMMITS: [R] (  9) Brady Eidson
UNREVIEWED COMMITS: [R] (  8) Filip Pizlo
UNREVIEWED COMMITS: [R] (  7) Simon Hausmann
UNREVIEWED COMMITS: [R] (  7) Julien Chaffraix
UNREVIEWED COMMITS: [R] (  6) Nate Chapin
UNREVIEWED COMMITS: [R] (  6) Gavin Barraclough
UNREVIEWED COMMITS: [R] (  6) Brent Fulgham
UNREVIEWED COMMITS: [R] (  5) Timothy Hatcher
UNREVIEWED COMMITS: [R] (  4) Michael Saboff
UNREVIEWED COMMITS: [R] (  4) Mark Hahnenberg
UNREVIEWED COMMITS: [R] (  4) Jer Noble
UNREVIEWED COMMITS: [R] (  4) Dirk Pranke
UNREVIEWED COMMITS: [R] (  4) Darin Adler
UNREVIEWED COMMITS: [R] (  3) Chris Fleizach
UNREVIEWED COMMITS: [R] (  2) Yury Semikhatsky
UNREVIEWED COMMITS: [R] (  2) Xan Lopez
UNREVIEWED COMMITS: [R] (  2) Tim Horton
UNREVIEWED COMMITS: [R] (  2) Kentaro Hara
UNREVIEWED COMMITS: [R] (  2) Dmitry Titov
UNREVIEWED COMMITS: [R] (  2) David Hyatt
UNREVIEWED COMMITS: [R] (  2) Antti Koivisto
UNREVIEWED COMMITS: [R] (  1) Zoltan Herczeg
UNREVIEWED COMMITS: [R] (  1) Philip Rogers
UNREVIEWED COMMITS: [R] (  1) Gustavo Noronha Silva
UNREVIEWED COMMITS: [R] (  1) Eric Seidel
UNREVIEWED COMMITS: [R] (  1) Brian Weinstein
UNREVIEWED COMMITS: [R] (  1) Antonio Gomes
UNREVIEWED COMMITS: [C] (102) Raphael Kubo da Costa
UNREVIEWED COMMITS: [C] ( 47) Patrick Gansterer
UNREVIEWED COMMITS: [C] ( 44) Roger Fong
UNREVIEWED COMMITS: [C] ( 35) Lucas Forschler
UNREVIEWED COMMITS: [C] ( 22) Jon Lee
UNREVIEWED COMMITS: [C] ( 15) Mark Lam
UNREVIEWED COMMITS: [C] ( 10) Hin-Chung Lam
UNREVIEWED COMMITS: [C] (  6) Yoshifumi Inoue
UNREVIEWED COMMITS: [C] (  6) Fady Samuel
UNREVIEWED COMMITS: [C] (  6) Adam Kallai
UNREVIEWED COMMITS: [C] (  5) Žan Doberšek
UNREVIEWED COMMITS: [C] (  5) Pavel Podivilov
UNREVIEWED COMMITS: [C] (  4) Balazs Kelemen
UNREVIEWED COMMITS: [C] (  3) Peter Kasting
UNREVIEWED COMMITS: [C] (  3) Ilya Tikhonovsky
UNREVIEWED COMMITS: [C] (  3) Chris Evans
UNREVIEWED COMMITS: [C] (  2) Takashi Sakamoto
UNREVIEWED COMMITS: [C] (  2) Pierre Rossi
UNREVIEWED COMMITS: [C] (  2) Kenichi Ishibashi
UNREVIEWED COMMITS: [C] (  2) Karen Grunberg
UNREVIEWED COMMITS: [C] (  2) Antoine Quint
UNREVIEWED COMMITS: [C] (  2) Andrey Adaykin
UNREVIEWED COMMITS: [C] (  2) Adam Klein
UNREVIEWED COMMITS: [C] (  1) Xiaohai Wei
UNREVIEWED COMMITS: [C] (  1) Xianzhu Wang
UNREVIEWED COMMITS: [C] (  1) W. James MacLean
UNREVIEWED COMMITS: [C] (  1) Vincent Scheib
UNREVIEWED COMMITS: [C] (  1) Terry Anderson
UNREVIEWED COMMITS: [C] (  1) Silvia Pfeiffer
UNREVIEWED COMMITS: [C] (  1) Sadrul Habib Chowdhury
UNREVIEWED COMMITS: [C] (  1) Raymond Toy
UNREVIEWED COMMITS: [C] (  1) Rafael Weinstein
UNREVIEWED COMMITS: [C] (  1) Mikhail Pozdnyakov
UNREVIEWED COMMITS: [C] (  1) Mike Lawther
UNREVIEWED COMMITS: [C] (  1) Michael Nordman
UNREVIEWED COMMITS: [C] (  1) Mark Pilgrim
UNREVIEWED COMMITS: [C] (  1) Luciano Wolf
UNREVIEWED COMMITS: [C] (  1) Leo Yang
UNREVIEWED COMMITS: [C] (  1) Lauro Neto
UNREVIEWED COMMITS: [C] (  1) Jesus Sanchez-Palencia
UNREVIEWED COMMITS: [C] (  1) Jeffrey Pfau
UNREVIEWED COMMITS: [C] (  1) Hayato Ito
UNREVIEWED COMMITS: [C] (  1) Dominic Mazzoni
UNREVIEWED COMMITS: [C] (  1) Dmitry Gorbik
UNREVIEWED COMMITS: [C] (  1) Dave Barton
UNREVIEWED COMMITS: [C] (  1) Dana Jansens
UNREVIEWED COMMITS: [C] (  1) Andras Becsi
UNREVIEWED COMMITS: Total 1660

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.