[Webkit-unassigned] [Bug 114742] [texmap] draw content if graphics layer displays a video

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=114742





--- Comment #13 from Víctor M. Jáquez L. <vjaquez at igalia.com>  2013-04-26 11:12:16 PST ---
Hi Simon,

Thanks your patience. 

(In reply to comment #12)
> (From update of attachment 199679 [details])
> This is also wrong. I'm not sure why you think that having accelerated video means that you have to call setDrawsContent() on the main graphics layer.

That seems to me more "logical", but yeah, I spent all this day trying to figure out what mac does, and I've realized that what I'm proposing it is not right.

> 
> The graphics layer can have a contents layer for various reasons: video, WebGL, image, solid color. On Mac at least, none of those types of content layer need to be explicitly drawn (although WebGL does need a hint that the contents have changed sometimes).

Yes, I saw that today.

> 
> In the TextureMapper case, does the video go into a contents layer?

AFAIK, Yes it does.

In bug #86410, we defined the MediaPlayerPrivate as a TextureMapperPlatformLayer. After updating the texture with the video buffer, the MediaPlayerPrivate will request a ::repaint() to the RenderObject.

Here's a sequence diagram which help to understand the code flow:

http://people.igalia.com/vjaquez/images/repaint-seq.png

But the buffer won't be draw if setDrawContents() is set to false, and that happens when no media controls are drawn.


> In this case, is it considered like painted content that needs backing store?

Sorry, I don't follow your question.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.